Removed time.sleep() from accelrometer and magnometer reading methods. #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
approved these changes
Jul 15, 2024
Contributor
FoamyGuy
left a comment
FoamyGuy
left a comment
There was a problem hiding this comment.
I pushed a commit to fix the docs build. sphinx was trying to "follow" the reference to board.I2C but not finding it in the cpython docs build environment. Using double tick marks makes it still an inline code formatted string, but won't try to find it's reference.
This looks good to me. Thanks for submitting the fix @42xnor!
I don't have a sensor to test on.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 16, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_ENS160 to 1.0.7 from 1.0.6: > Merge pull request adafruit/Adafruit_CircuitPython_ENS160#5 from bablokb/no-reset Updating https://github.com/adafruit/Adafruit_CircuitPython_ICM20X to 2.0.21 from 2.0.20: > Merge pull request adafruit/Adafruit_CircuitPython_ICM20X#24 from 42xnor/remove-accelrometer-sleep-calls Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 1.0.3 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#65 from adafruit/better-error-sideset-delay Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_HDC302x Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issue #15 and has been sucessfully tested on a Raspberry Pi 4 B with an ICM20948. Similar to Pull Request #20 but only removes the time.sleep() calls, saving 20ms per imu.acceleration access and 5ms per imu.magnetic access.