Skip to content

Conversation

@tekktrik
Copy link
Member

@tekktrik tekktrik commented Jan 7, 2022

  1. Updates to type annotations, mostly just adding things I should have added the first time~
  2. Added or update method and class docstring Sphinx parameters so they'll show up on RTD
  3. Added bargraph so it will show in the API reference
  4. Fixed the page names for segments and matrix to be consistent with other libraries (now shows the filename)

@tannewt tannewt requested a review from a team January 7, 2022 18:41
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @tekktrik. Tested successfully with Feather RP2040, matrix featherwing and 4x7segment feather wing.

@FoamyGuy FoamyGuy merged commit ea1f0de into adafruit:main Jan 10, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 10, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_DPS310 to 2.1.0 from 2.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_DPS310#20 from FoamyGuy/default_import

Updating https://github.com/adafruit/Adafruit_CircuitPython_EMC2101 to 1.1.10 from 1.1.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_EMC2101#20 from stoklund/full_speed
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 4.1.9 from 4.1.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#95 from tekktrik/doc/update-documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants