Fixing matrix.fill color flipping #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swapping the _set_buffer() parameters so that when the matrix is filled it shows the proper color. This fixes part of issue #102. Tested with a QT Py RP2040 running CP8 and an 8x8 BiColor matrix I tried working on shifting to get the color to remain as expected but that's a little over my head at the moment. Also changing two ValueError() strings to f strings per pylint
makermelissa
approved these changes
Feb 21, 2023
Collaborator
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
Looks good. Thanks.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 22, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 4.6.3 from 4.6.2: > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#113 from adafruit/matrix_fill_color_swap Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.3.0 from 7.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#155 from vladak/recv_into_cleanup > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#145 from vladak/tls_port_detection Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swapping the
_set_buffer()parameters so that when the matrix is filled it shows the proper color. This fixes part of issue #102 Tested with a QT Py RP2040 running CP8 and an 8x8 BiColor matrixI tried working on shifting to get the color to remain as expected but that's a little over my head at the moment. Also changing two
ValueError()strings to f strings per pylint