Add type annotations #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for type annotations
ladyada
approved these changes
Feb 23, 2022
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 24, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_Gizmo to 1.3.8 from 1.3.7: > Merge pull request adafruit/Adafruit_CircuitPython_Gizmo#23 from tekktrik/doc/add-typing > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_ServoKit to 1.3.8 from 1.3.7: > Merge pull request adafruit/Adafruit_CircuitPython_ServoKit#37 from tekktrik/doc/add-typing > Fixed readthedocs build > Consolidate Documentation sections of README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #22 by adding type annotations! Had to disable duplicate code warning for pylint in order to get it to pass CI.
I'm probably going to work on a follow up PR to add more RTD documentation in the docstrings.