Reordered init sequence for MiniTFT for improved stability #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
Feb 26, 2020
Collaborator
Author
|
Ok, this fixes the reset error and it looks like it might have helped with uncovering something else in another library. |
|
i can confirm that this fix works for me (MiniTFT Featherwing, Feather M4 Express; CP 5.0 beta 5 with feb 21 libraries (mpy_5x) other than the updated minitft_featherwing.py) |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 27, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 1.9.8 from 1.9.7: > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#57 from makermelissa/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I compared this to the arduino code and reordered it a bit. I'm setting the TFT reset last just to make sure it's definitely an output. Should fix #56.