Added GPS FeatherWing #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Also, I have tested this on the Feather M4 Express and the Feather nRF52840 Express. |
kattni
suggested changes
Feb 23, 2019
Contributor
kattni
left a comment
kattni
left a comment
There was a problem hiding this comment.
Looks great! One minor cosmetic suggestion.
|
|
||
| def update(self): | ||
| """ | ||
| Make sure to call gps.update() every loop iteration and at least twice |
Contributor
There was a problem hiding this comment.
If you wan it to show up as code in the docs, you can put double backticks on either side (``). Single backticks will cause sphinx to attempt to do something with it, double tells sphinx that you're trying to display something in fixed-width font.
Contributor
There was a problem hiding this comment.
I'm referring to gps.update().
Collaborator
Author
There was a problem hiding this comment.
Thanks! I didn't know that.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 24, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 1.0.1 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#3 from ladyada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 1.7.1 from 1.5.0: > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#31 from jerryneedell/jerryn_gps > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#29 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#28 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_PyPortal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, here's the GPS FeatherWing code. It handles the initialization automatically, makes some properties shorter names and has some speed calculations such as providing the speed in MPH and KPH.