Reduce the CPU load when waiting for the display #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In many places a `pass` instruction is used in loops to wait until we hear back back from the display. This causes the loop to execute continuously which uses all of the available CPU, if we instead sleep for 1ms, we don't lose much time (less than 1ms each wait) and we dramatically reduce the load on the CPU. Before the change (updating a 3-color 2.13" display): ``` time python3 ./update_display real 0m19.664s user 0m17.622s sys 0m1.046s ``` After the change: time python3 ./update_display real 0m19.730s user 0m3.563s sys 0m0.792s1 The total time to run the script is about the same, but the CPU time has reduced dramatically.
Member
|
@makermelissa maybe check it still works on a feather m4 + wing in the next week or two? :) |
Collaborator
|
I tried this out with a Feather M4 and both the mono and tri-color and neither worked. So then I tried the original code before this change and it didn't work for either display again, so I'll have to look into it further. |
Collaborator
|
Ok! I got it working. It tested fine on both the mono and tri-color displays. |
makermelissa
approved these changes
Feb 11, 2020
Collaborator
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
Looks good and tested fine.
Contributor
Author
|
🙌 thank you so much :) |
Collaborator
|
Thank you! |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 11, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_EPD to 2.5.2 from 2.5.1: > Merge pull request adafruit/Adafruit_CircuitPython_EPD#35 from mariovisic/nice_to_cpu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many places a
passinstruction is used in loops to wait until we hear backback from the display. This causes the loop to execute continuously which uses
all of the available CPU, if we instead sleep for 1ms, we don't lose much time
(less than 1ms each wait) and we dramatically reduce the load on the CPU.
Before the change (updating a 3-color 2.13" display):
After the change:
The total time to run the script is about the same, but the CPU time has reduced dramatically.