Skip to content

Conversation

@rhooper
Copy link
Contributor

@rhooper rhooper commented May 11, 2020

This PR can't be merged because the build is failing on black. I don't intend to fix that, because I can't bring myself to contribute code with function arguments formatted the way black wants them formatted.

Black also runs first, preventing visibility into other issues with sphinx and pylint.
I moved it to the end so it can be pesky last.

As such, I will submit this PR for reference only. I expect it to be rejected.

@kattni
Copy link
Contributor

kattni commented May 11, 2020

This PR requires formatting changes to be considered for merging. As well, there were changes to the CI which would cause issues with patching as it no longer matches the standard CI.

Further, it appears that @dunkmann00 and @rhooper crossed paths.

Closing in favor or #48.

@kattni kattni closed this May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants