write data bit first before rising clock pin (in non hardware spi) #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

tannewt merged 1 commit into adafruit:master from schelmo:digitalio

Sep 30, 2019

Contributor

schelmo commented May 14, 2019

for #34


          write data bit first before rising clock pin (in non hardware spi)

045d6f8

kevinjwalters reviewed

View reviewed changes

kevinjwalters left a comment

Code looks good to me. My dotstar strip is on loan so I cannot test this physically.

tannewt approved these changes

View reviewed changes

Member

tannewt left a comment

Sorry we missed this! I verified that DotStars do capture on the rising edge. Thanks!

tannewt merged commit 294502c into adafruit:master

kattni mentioned this pull request

_ds_writebytes() clock rises before data is written #34

Closed

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request


          Automated update by Adabot (adafruit/adabot@f7bbfc2)

157941d

Updating https://github.com/adafruit/Adafruit_CircuitPython_DotStar to 1.5.1 from 1.5.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#38 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#39 from adafruit/revert-36-bitbangio
  > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#36 from schelmo/bitbangio
  > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#35 from schelmo/digitalio

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.1.4 from 3.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#56 from makermelissa/master
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#55 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#39 from kevinjwalters/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_SGP30 to 2.1.0 from 2.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_SGP30#20 from Airviz/multiple-featureset-values
  > Merge pull request adafruit/Adafruit_CircuitPython_SGP30#18 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1325 to 1.1.1 from 1.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1325#4 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyBadger to 0.9.2 from 0.9.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#8 from makermelissa/master
  > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#6 from adafruit/dherrada-patch-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet