corrected index replacement of tileGrid, and deletion of unused tileGrids #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makermelissa
approved these changes
Jul 13, 2020
Collaborator
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
Tested and it's working perfectly now on both PyPortal and Raspberry Pi.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 14, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.7.10 from 2.7.9: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#69 from kmatch98/bitmap_zero Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 0.11.5 from 0.11.4: > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#34 from adafruit/readme-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 2.4.0 from 2.3.4: > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#61 from georgebohnisch/master > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#60 from rhooper/ring_support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is resolves leftover characters as identifed in: #67.
The issue was related to the skipping of the tileGrid elements when a blank glyph is present. I created a different tilegrid_count index to resolve this.