Quick and dirty workaround for #45 #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
approved these changes
May 29, 2020
Contributor
FoamyGuy
left a comment
FoamyGuy
left a comment
There was a problem hiding this comment.
Thank you @jimbobbennett for finding this issue and creating the workaround!
I tested this fix on Edge Badge with CP 5.3.0 and can confirm I am seeing the same exception raised from the recent library release when I do not set the text value in the constructor.
This fix does resolve the issue and allow the text to be set properly with the setter.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 31, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.6.1 from 2.6.0: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#47 from kmatch98/fix_anchoring > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#46 from jimbobbennett/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.