Fixed off by one error with diagonal lines #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

makermelissa merged 1 commit into adafruit:master from makermelissa:master

Nov 3, 2020

Collaborator

makermelissa commented Nov 3, 2020

Fixes #26.


          Fixed off by one error with diagonal lines

4778fc0

makermelissa requested a review from a team

November 3, 2020 23:19

FoamyGuy approved these changes

View reviewed changes

FoamyGuy left a comment

I tested this successfully with Matrix Portal the diagonal line from the code in the issue now properly draws 3 pixels long (0,0), (1,1), (2,2).

Looks good to me.

makermelissa merged commit 64eb9da into adafruit:master

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request


          Automated update by Adabot (adafruit/adabot@c01bb3a)

8fe08c6

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.6.1 from 3.6.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#91 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Shapes to 2.0.2 from 2.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Shapes#27 from makermelissa/master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet