Fix default end values. #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tested and works. Thanks for quick fix @dhalbert |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 19, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 4.2.1 from 4.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#45 from dhalbert/fix-end-values Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.4.0 from 2.3.2: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#35 from FoamyGuy/master Updating https://github.com/adafruit/Adafruit_CircuitPython_PyBadger to 1.1.1 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#20 from nnja/fix_business_card_display
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44.
I2CDevice was passing
Noneas a default value forendin read and write operations onbusio.I2Cobjects. Thebusio.I2Cdocumentation says thatNonewill work, but it does not:len(buf)must be passed instead as the default.If
busio.I2Cwere fixed to allowNone, this change could be reverted.