setup.py fixes for correct pip installation #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattni
approved these changes
Mar 18, 2020
Contributor
kattni
left a comment
kattni
left a comment
There was a problem hiding this comment.
Good catch! Thank you for the fix!
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Mar 19, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_Bitmap_Font to 1.1.0 from 1.0.5: > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#19 from andreamah/pip-installation-fix > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#17 from adafruit/pylint-update > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#16 from sommersoft/patch_coc > update pylintrc for black > build.yml: move pylint, black, and Sphinx installs to each repo; add description to 'actions-ci/install.sh' Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 2.1.1 from 2.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#24 from brentru/remove-debug-kwarg-in-examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #18 , the PyPI installation was only installing the *.egg-info directory and did not install the library itself. This happened when I used
pip3 install adafruit-circuitpython-bitmap_fontand when I tried to pip install directly from the *.tar.gz file.By making this change, I was able to install correctly from the *.tar.gz file 😀.