Skip to content

defer creating buffers until MTU is known #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2020
Merged

defer creating buffers until MTU is known #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions adafruit_ble_cycling_speed_and_cadence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,8 @@ class CyclingSpeedAndCadenceService(Service):

def __init__(self, service=None):
super().__init__(service=service)
self._measurement_buf = bytearray(
self.csc_measurement.packet_size # pylint: disable=no-member
)
# Defer creating buffer until we're definitely connected.
self._measurement_buf = None

@property
def measurement_values(self):
Expand All @@ -169,6 +168,10 @@ def measurement_values(self):
# uint16: Last Crank Event Time, in 1024ths of a second
#

if self._measurement_buf is None:
self._measurement_buf = bytearray(
self.csc_measurement.incoming_packet_length # pylint: disable=no-member
)
buf = self._measurement_buf
packet_length = self.csc_measurement.readinto(buf) # pylint: disable=no-member
if packet_length == 0:
Expand Down