Skip to content

Fix packet length check in _update() #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Fix packet length check in _update() #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion adafruit_ble_apple_media.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def _update(obj):
obj._buffer = bytearray(128)
length_read = obj._entity_update.readinto(obj._buffer)
if length_read > 0:
if length_read < 4:
if length_read < 3:
raise RuntimeError("packet too short")
# Even though flags is currently unused, if it were removed, it would cause there to be
# too many values to unpack which would raise a ValueError
Expand Down