add BLERadio properties; add name and tx_power to advertisement scan_response #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Dec 5, 2019
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Two minor comment comments but good otherwise. Thanks!
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 9, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 3.1.0 from 3.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_BLE#40 from tannewt/support_magic_light > Merge pull request adafruit/Adafruit_CircuitPython_BLE#39 from dhalbert/bleradio-name-address > Merge pull request adafruit/Adafruit_CircuitPython_BLE#38 from tannewt/support_ancs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35 and #36.
BLERadio.name, which sets and gets_bleio.Adapter.nameBLERadio.tx_power, which now is just 0. Setting is not yet implemented (need anAdapterAPI).BLERadio.address_bytes, which gets_bleio.Adapter.address.address_bytes. I didn't want to expose or wrap_bleio.Address, and getting the bytes is the main use case.scan_responseis supplied toBLERadio.start_advertising(), a default scan response is generated, which contains.nameas the COMPLETE_NAME, and.tx_power.Originally I added an optional argument to
.start_advertising()to specify the name. But that doesn't set the name used in the Generic Information Service, and the Bluefruit LE app uses that GIS name in preference to the advertising name, which is confusing. Presumably other apps do this too. So it's good to make the advertising name and the GIS name the same. So the way to use this is: