Skip to content

Conversation

@evaherrada
Copy link
Collaborator

No description provided.

@evaherrada evaherrada requested a review from kattni November 27, 2019 20:01
Copy link
Contributor

@siddacious siddacious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though please also remove the .travis.yml

@evaherrada
Copy link
Collaborator Author

@siddacious done

Copy link
Contributor

@siddacious siddacious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the build.yml wasn't added because the .gitignore was updated after it was added. Go ahead and add it again

@evaherrada
Copy link
Collaborator Author

@siddacious Ok, I've pushed that file. That's good to know so I can make sure to do it in that order when I automate it

@siddacious siddacious merged commit 1a97dd4 into master Nov 27, 2019
@siddacious
Copy link
Contributor

@dherrada looks good; I'll merge, then make a PR against this library with some change with a pylint error and we'll see if it works!

@evaherrada
Copy link
Collaborator Author

@siddacious Ok

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Nov 28, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_74HC595 to 1.0.3 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_74HC595#5 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_74HC595#4 from adafruit/dherrada-patch-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants