work around readPicture short read glitch #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some situations, the data returned will be short a byte. That byte will show up on the next request, prepended to the request data which then fails validation. This change will deal with up to 5 such glitches by allowing skipping over the trailer data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some situations, the data returned will be short a byte. That byte will show up on all subsequent requests as if a buffer within the camera is simply off by one. But then it can happen again and the buffer will be off by more bytes.
This change will deal with up to 5 such glitches by assuming we don't really need the trailer data.
I don't know if this is worth merging as the situation must somehow being completely dependent on the combination of hardware I'm using. If this was happening to others the camera would be totally useless.
I'm mainly putting this here in the hopes of maybe finding someone else who has experienced this. Maybe there is a better workaround? Or perhaps my camera is broken.
This was tested with a Arduino Nano 33 BLE using modified example code to dump base64 image data over the serial link. https://gist.github.com/rhettg/7d06ef5a08a11b45aa1a65104774c341