Skip to content

Conversation

kengdoj
Copy link
Collaborator

@kengdoj kengdoj commented Dec 1, 2023

replace broken link with existing "whitespace" glossary term

This will require a 2 weeks Call for Review << new rule, or substantial changes affecting a large number of test cases, if in doubt, use this. >>


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

Jym77
Jym77 previously requested changes Dec 7, 2023
@kengdoj kengdoj requested a review from Jym77 December 7, 2023 14:13
@kengdoj kengdoj dismissed Jym77’s stale review December 12, 2023 14:12

suggestion accepted.

@kengdoj kengdoj requested a review from dd8 December 12, 2023 19:21
@kengdoj kengdoj merged commit c4a040d into develop Jan 12, 2024
@kengdoj kengdoj deleted the kengdoj-matchingcharsdef branch January 12, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants