Skip to content
This repository was archived by the owner on Aug 3, 2025. It is now read-only.

Rename yaml names #13

Merged
merged 2 commits into from
May 18, 2017
Merged

Rename yaml names #13

merged 2 commits into from
May 18, 2017

Conversation

@sameetandpotatoes
Copy link
Member

@sameetandpotatoes sameetandpotatoes commented May 15, 2017

  • Must be merged with other PRs

@sameetandpotatoes sameetandpotatoes mentioned this pull request May 15, 2017
Merged
5 tasks
bcongdon
bcongdon approved these changes May 16, 2017
View reviewed changes
Copy link
Member

@bcongdon bcongdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a warning that this config change will need to be reflected in production, or else deploying will fail on the next sync.

@sameetandpotatoes sameetandpotatoes merged commit 1b3d683 into master May 18, 2017
@sameetandpotatoes
Copy link
Member Author

sameetandpotatoes commented May 18, 2017

Yeah, I made the database key-value pair already change for all ruby services (copied over what is currently the production key into the database key, so when we do a redeploy, that change should work)

@sameetandpotatoes sameetandpotatoes deleted the rename_yaml_names branch May 18, 2017 14:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bcongdon bcongdon bcongdon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sameetandpotatoes @bcongdon