Skip to content

Only ensure a CbrainFileList read access at task launch, resolves #1057 #1417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Only ensure a CbrainFileList read access at task launch, resolves #1057 #1417

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
beac31a
Only ensure a CbrainFileList read access at task launch, resolves #1057
MontrealSergiy Jul 30, 2024
8096a38
Only ensure a CbrainFileList read access at task submission, resolves…
MontrealSergiy Jul 30, 2024
79117c7
Removing a redundancy/ beatification for ensure a CbrainFileList read…
MontrealSergiy Aug 5, 2024
ea91eb4
drop old style boutiques and additional checks
MontrealSergiy Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions BrainPortal/app/controllers/tasks_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,14 +235,19 @@ def new #:nodoc:

# Filter list of files as provided by the get request
file_ids = params[:file_ids] || []
cb_file_ids = CbrainFileList.where(:id => file_ids).pluck(:id)
other_file_ids = file_ids.map(&:to_i) - cb_file_ids
if @tool_config.try(:inputs_readonly) || @task.class.properties[:readonly_input_files]
access = :read
else
access = :write
end
@files = Userfile.find_accessible_by_user(file_ids, current_user, :access_requested => access) rescue []
if @files.count == 0
flash[:error] = "You must select at least one file to which you have write access."
cb_files = Userfile.find_accessible_by_user(cb_file_ids, current_user, :access_requested => :read) rescue []
other_files = Userfile.find_accessible_by_user(other_file_ids, current_user, :access_requested => access) rescue []
@files = cb_files + other_files
if @files.count != file_ids.count
flash[:error] = "Select files to which you have #{access} access."
flash[:error] = "You must select at least one file." if @files.count == 0
redirect_to :controller => :userfiles, :action => :index
return
end
Expand Down