[login] Homepage header image and Partner Logos Panel #10051
Conversation
github-actions
bot
added
Language: SQL
|
Looks great! Maybe @christinerogers @jeffersoncasimir if this change would work for you too, then I can go ahead an approve it. Otherwise maybe it could be customizable whether the partners are its own panel or within the login page |
| INSERT INTO ConfigSettings (Name, Description, Visible, AllowMultiple, DataType, Parent, Label, OrderNumber) VALUES('login_logo_right_link', 'Optional link to redirect when clicking on top right logo', 1, 0, 'text', 1, 'Login Top Right Logo Link', 4); | ||
| INSERT INTO ConfigSettings (Name, Description, Visible, AllowMultiple, DataType, Parent, Label, OrderNumber) VALUES('partner_logos', 'Logos for partners to be displayed in the homepage', 1, 1, 'text', 1, 'Partner Logos', 4); | ||
|
|
||
| INSERT INTO Config (ConfigID, Value) VALUES ((SELECT ID FROM ConfigSettings WHERE Name="login_logo_left"), "/images/LORIS_logo_white.svg"); |
There was a problem hiding this comment.
Would it be possible to make the images work in an overridden project setting? I tried to change the logo to one in my project folder but it doesn't seem to work
INSERT INTO Config (ConfigID, Value) VALUES ((SELECT ID FROM ConfigSettings WHERE Name="login_logo_left"), "../project/images/ctu.png");
There was a problem hiding this comment.
its possible, that's what we do on CBIG. you would need to put the logo in the static directory of a project module. I have a project module specific to anything that can be reached by an anonymous user and another module for things that require login but basically the logos sit in the publicly accessible one.
There was a problem hiding this comment.
Ways to achieve this:
- Modify apache settings (see docs/config/apache2-site to see what your config probably is currently. you'll see how and why /images redirects images from htdocs/images, etc)
or - Use images.loris.ca - every project can have their own folder there
There was a problem hiding this comment.
I dont think we need to go that far, the project module way works fine
There was a problem hiding this comment.
Sorry, so the image would be at /project/static/images/ctu.png
And then I can reference it with what from config?
There was a problem hiding this comment.
@skarya22 What he means is that every module's static/ directory has the correct settings already. To override, you can place and reference an image in, for example: project/modules/login/static/ctu.png.
| opacity: 1; | ||
| -webkit-transition: opacity 0.2s ease-in; | ||
| transition: opacity 0.2s ease-in; | ||
| .logo-right { |
There was a problem hiding this comment.
With the sizing changes, the github logo looks blurry now. Could you update it to be a higher quality image, or change to an svg?
There was a problem hiding this comment.
I have updated the asset to a svg
| -webkit-transition: opacity 0.2s ease-in; | ||
| transition: opacity 0.2s ease-in; | ||
| .logo-right { | ||
| margin-left: auto; |
There was a problem hiding this comment.
The logos feel a little too big on mobile devices now
There was a problem hiding this comment.
adjust the mobile display of the asset to be smaller
skarya22
added
the
Passed manual tests
4 participants
Partner logos are defined
Partner logos are not defined
