Fix request format and allow for files in request #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NooNoo1337
reviewed
Jan 25, 2022
|
|
||
| private createFormData(input: Record<string, unknown>): FormData { | ||
| return Object.keys(input || {}).reduce((formData, key) => { | ||
| let property = input[key]; |
There was a problem hiding this comment.
suggestion: lets make it as const. The value of variable doesn't change
| for (const formItem of propertyContent) { | ||
| formData.append( | ||
| key, | ||
| formItem instanceof Blob || formItem instanceof File |
There was a problem hiding this comment.
suggestion: to make external variable for condition to simplify double ternary condition.
const isFileType = formItem instanceof Blob || formItem instanceof File;
| {}; | ||
| const requestParams = this.mergeRequestParams(params, secureParams); | ||
| const responseFormat = (format && this.format) || void 0; | ||
| const responseFormat = format || this.format || void 0; |
| key, | ||
| formItem instanceof Blob || formItem instanceof File | ||
| ? formItem | ||
| : typeof formItem === "object" && formItem !== null |
There was a problem hiding this comment.
suggestion: get rid of the nested condition. Because it is hard to read and understand from scratch.
? formItem : stringifyFormItem(formItem)
stringifyFormItem(formItem) {
if( typeof formItem === "object" && formItem !== null ) return JSON.stringify(formItem);
return `${formItem}`;
}
allow for file array in form data requests
Contributor
Author
|
@NooNoo1337 change requests applied :) |
|
Awesome! Thank you c: |
Member
|
@kuamanet hello, thank you for your Pull Request, can you resolve conflicts on this branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #293
Fix #251