Use c12 for wider configuration file format support
#1144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f5a5f76 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Sora Morimoto <[email protected]>
smorimoto
changed the title
c12 for better config managementc12 for wider configuration file format support
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors custom configuration loading by replacing the URL-based import and logging with the loadConfig function from the c12 package, enabling support for a wider configuration file format.
- Replace URL-based custom configuration loading with c12's loadConfig.
- Remove now-unused dependencies (node:url and consola).
- Update the changeset file to document the minor version update for swagger-typescript-api.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| index.ts | Refactored configuration loading by using c12’s loadConfig. |
| .changeset/fancy-actors-wait.md | Updated changeset with a minor version bump and descriptive text. |
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (1)
index.ts:335
- Ensure that loadConfig returns an object with a valid 'config' property before spreading it. Consider adding a check or a default value to handle cases where custom configuration may be absent.
...customConfig.config,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1140