Skip to content

Conversation

@MarkusAbtion
Copy link
Member

No description provided.

Before it was checking unstaged files, which of course only works locally
@jeppester
Copy link
Contributor

I'm not an expert on jekyll, but it would seem to me that adding "last updated" would be a good task for a jekyll plugin which we would add in https://github.com/abtion/guidelines/blob/main/_config.yml

Did you consider something like that?

I'd prefer it to happen during the build rather than as an automated commit.

Copy link
Contributor

@hcarreras hcarreras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems overly complicated, but it is low risk if it breaks - so I'd say yey!

Copy link
Member

@runephilosof-abtion runephilosof-abtion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will work as expected.

https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication

When you use the repository's GITHUB_TOKEN to perform tasks, events triggered by the GITHUB_TOKEN, with the exception of workflow_dispatch and repository_dispatch, will not create a new workflow run. This prevents you from accidentally creating recursive workflow runs. For example, if a workflow run pushes code using the repository's GITHUB_TOKEN, a new workflow will not run even when the repository contains a workflow configured to run when push events occur.

Commits pushed by a GitHub Actions workflow that uses the GITHUB_TOKEN do not trigger a GitHub Pages build.

Copy link
Member

@runephilosof-abtion runephilosof-abtion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's https://github.com/gjtorikian/jekyll-last-modified-at. I think it requires the workflow to check out the entire git history instead of depth 1, but that should not be a problem.

But as mentioned here https://tomkadwill.com/adding-last-modified-date-to-jekyll, it gives very little control and it might be nicer to control manually.
Although, that does introduce the risk of forgetting to update it. Maybe a reminder can be made in a PR comment if you haven't updated the timestamp?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants