fix(bump): auto-increment prerelease when tag already exists #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@TimothyJones Sorry for pinging you, but could you get this reviewed? If this isn't meeting any of the requirements, I'm happy to fix it |
Member
|
Apologies, I thought I had done this one already, but clearly I hadn't. Thanks for the tag, much appreciated! Code looks fine to me - can you add a note to the readme that explains this behaviour? Then I'll release asap. |
Update readme explaining how --prerelease automatically increments the numeric suffix when a tag already exists for the same base version and prerelease channel.
Author
|
Sorry for taking so long on my side. Updated the README and signed previous commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--prerelease, we now check existing git tags (respectingtagPrefix) for the same base version and prerelease channel.v1.4.3-xyz.0), we auto-increment to the next available (e.g.,v1.4.3-xyz.1) before tagging.-0,-1), applying the same collision-avoidance.Fixes: #211