feat(updater): add maven pom.xml file support (#33, #109) #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@TimothyJones Can you review, please? |
TimothyJones
approved these changes
Jan 15, 2024
Member
TimothyJones
left a comment
TimothyJones
left a comment
There was a problem hiding this comment.
Looks great, thanks so much!
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #123 +/- ##
==========================================
- Coverage 94.43% 94.11% -0.32%
==========================================
Files 25 26 +1
Lines 467 493 +26
==========================================
+ Hits 441 464 +23
- Misses 26 29 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! As I commented here, on the PR #109, these are the changes that add support for Maven projects, using the
pom.xmlversion file.All the work has been done by @paul-barton, but since the PR #109 hasn't had any updates in a while, I have forked it, fixed the tests, and fixed the updater configuration, and it's now working fine!
This PR is part of the updaters for non-node projects, as explained on Issue #33.