Filter out empty values from install_requires
#250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnobelis
force-pushed
the
nnobelis/non_empty_install_requires
branch
from
df95e22 to
4ecf5cd
Compare
MarcelBochtler
force-pushed
the
nnobelis/non_empty_install_requires
branch
2 times, most recently
from
823421c to
8826952
Compare
Signed-off-by: Marcel Bochtler <[email protected]>
Sometimes, when the `--analyze-setup-py-insecurely` parameter is used, the requirements resolution can contain some empty elements. For instance for gnupg-2.3.1/gnupg-2.3.1/setup.py, the requirements are resolved to ['psutil>=1.2.1', '']. The second element of this array crashes the Python Inspector. This commit fixes the issue by removing empty elements from the array. Resolves aboutcode-org#247. Signed-off-by: Nicolas Nobelis <[email protected]>
MarcelBochtler
force-pushed
the
nnobelis/non_empty_install_requires
branch
from
8826952 to
708b3be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, when the
--analyze-setup-py-insecurelyparameter is used, the requirements resolution can contain some empty elements. For instance for gnupg-2.3.1/gnupg-2.3.1/setup.py, the requirements are resolved to ['psutil>=1.2.1', '']. The second element of this array crashes the Python Inspector.This commit fixes the issue by removing empty elements from the array.
Resolves #247.