Skip to content

Conversation

mattheworiordan
Copy link
Member

The copy previously made it sounds like only messages sent were counted, which could be confusing for users who think this is messages sent to Ably, or sent from Ably, but not both.

See somewhat related Slack message which surfaced this.

Copy link

coderabbitai bot commented Jul 25, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch stats-description-improvement

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Comment on lines 378 to 381
| messages.all.all.count | Total number of messages that were successfully received or sent by Ably, summed over all message types and transports. |
| messages.all.all.billableCount | Total number of billable messages that were successfully received or sent by Ably, summed over all message types and transports. |
| messages.all.all.data | Total data in messages successfully received or sent by Ably, summed over all message types and transports. |
| messages.all.all.uncompressedData | Total data in messages successfully received or sent by Ably, excluding savings provided delta compression. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 'received and sent' rather than 'or' in that case?

@SimonWoolf
Copy link
Member

Could we consider making these sort of wording improvements in the authoritative schema at https://github.com/ably/ably-common/blob/main/json-schemas/src/app-stats.json , and having a docs repo script that populates this table from that we can run every so often? So we're not making different wording improvements to the two independently.

@m-hulbert m-hulbert force-pushed the stats-description-improvement branch from 51b8cfc to 8d374c2 Compare September 1, 2025 09:12
@m-hulbert
Copy link
Contributor

Sorry, dropped the ball on this in the MDX conversion.

I've rebased this to fix it for now (with my suggested change included).

@SimonWoolf I think that's a really sensible idea. I'll add it to my list to look at standardising in the schema 👍

@m-hulbert m-hulbert requested a review from GregHolmes September 1, 2025 09:19
@m-hulbert m-hulbert merged commit 26aa78d into main Sep 1, 2025
6 checks passed
@m-hulbert m-hulbert deleted the stats-description-improvement branch September 1, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants