Skip to content

Ported back new grammar changes from C++ to Python implementation #1637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 7, 2024
Merged

Ported back new grammar changes from C++ to Python implementation #1637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
45d2252
Backported . (any chat) from llama.cpp
ExtReMLapin Jul 29, 2024
90c2bc4
unfinished {count,optionalmax)
ExtReMLapin Jul 29, 2024
5c050e8
implemented slice function in std:vector
ExtReMLapin Jul 29, 2024
4c74a82
fixed mistake done while reading
ExtReMLapin Jul 29, 2024
1fd8840
ported https://github.com/ggerganov/llama.cpp/pull/7194
ExtReMLapin Jul 29, 2024
81cf909
multiple fixes, var copy
ExtReMLapin Jul 30, 2024
9fb809f
Merge branch 'main' into patch-1
ExtReMLapin Aug 1, 2024
71eef77
Merge branch 'main' into patch-1
abetlen Aug 4, 2024
6d53877
Rewrite LlamaGrammar internals in python style
abetlen Aug 4, 2024
7308d53
bugfix
abetlen Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llama_cpp/llama_cpp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3002,7 +3002,7 @@ def llama_grammar_init(
n_rules: Union[ctypes.c_size_t, int],
start_rule_index: Union[ctypes.c_size_t, int],
/,
) -> llama_grammar_p:
) -> Optional[llama_grammar_p]:
"""Initialize a grammar from a set of rules."""
...

Expand Down
Loading