feat: auto switch wallet connector #2590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
mgrabina
reviewed
Aug 19, 2025
|
|
||
| // Attempt switch and handle completion | ||
| switchNetwork(chainId).finally(() => { | ||
| setIsAutoSwitching(false); |
There was a problem hiding this comment.
Suggested change
| setIsAutoSwitching(false); | |
| setIsAutoSwitching(false); | |
| setHasAttemptedAutoSwitch(true); |
|
|
||
| // Auto-attempt network switch on mount | ||
| useEffect(() => { | ||
| if (autoSwitchOnMount && !hasAttemptedAutoSwitch) { |
There was a problem hiding this comment.
Suggested change
| if (autoSwitchOnMount && !hasAttemptedAutoSwitch) { | |
| if (autoSwitchOnMount && !hasAttemptedAutoSwitch && !isAutoSwitching) { |
| funnel, | ||
| ...event?.eventParams, | ||
| network: networkName, | ||
| automatic: true, |
There was a problem hiding this comment.
Suggested change
| automatic: true, | |
| manual: false, |
so we use the same prop
mgrabina
approved these changes
Aug 19, 2025
JoaquinBattilana
approved these changes
Aug 19, 2025
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Changes
Developer Notes
Add any notes here that may be helpful for reviewers.
Reviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
.env.examplefile as well as the pertinant.github/actions/*files