-
Notifications
You must be signed in to change notification settings - Fork 428
feat: net apy #2582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: net apy #2582
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
import { useWeb3Context } from 'src/libs/hooks/useWeb3Context'; | ||
import { useRootStore } from 'src/store/root'; | ||
|
||
import { useAppDataContext } from './app-data-provider/useAppDataProvider'; | ||
import { useUserYield } from './pool/useUserYield'; | ||
|
||
/** | ||
* Enhanced user yield hook that includes merit incentives in Net APY calculation | ||
* This provides a more comprehensive view of user returns including merit rewards | ||
*/ | ||
export const useEnhancedUserYield = () => { | ||
const { currentAccount } = useWeb3Context(); | ||
const currentMarketData = useRootStore((store) => store.currentMarketData); | ||
const { user } = useAppDataContext(); | ||
|
||
const enhancedUserYield = useUserYield(currentMarketData, currentAccount); | ||
|
||
const netAPYWithMerit = enhancedUserYield.data?.netAPY ?? user?.netAPY ?? 0; | ||
const earnedAPYWithMerit = enhancedUserYield.data?.earnedAPY ?? 0; | ||
const debtAPYWithMerit = enhancedUserYield.data?.debtAPY ?? 0; | ||
|
||
return { | ||
netAPY: netAPYWithMerit, | ||
earnedAPY: earnedAPYWithMerit, | ||
debtAPY: debtAPYWithMerit, | ||
loading: enhancedUserYield.isPending, | ||
error: enhancedUserYield.error, | ||
hasEnhancedData: !!enhancedUserYield.data, | ||
}; | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
import { useQuery } from '@tanstack/react-query'; | ||
import { convertAprToApy } from 'src/utils/utils'; | ||
|
||
import { MeritAction } from './useMeritIncentives'; | ||
|
||
type UserMeritIncentives = { | ||
totalAPR: number; | ||
actionsAPR: { | ||
[key in MeritAction]: number | null | undefined; | ||
}; | ||
}; | ||
|
||
type UserMeritIncentivesResponse = { | ||
previousAPR: UserMeritIncentives | null; | ||
currentAPR: UserMeritIncentives; | ||
}; | ||
|
||
const url = 'https://apps.aavechan.com/api/merit/aprs'; | ||
|
||
export const useUserMeritIncentives = (userAddress?: string) => { | ||
return useQuery({ | ||
queryFn: async () => { | ||
if (!userAddress) { | ||
return null; | ||
} | ||
|
||
const response = await fetch(`${url}?user=${userAddress}`); | ||
const data: UserMeritIncentivesResponse = await response.json(); | ||
|
||
return data; | ||
}, | ||
queryKey: ['userMeritIncentives', userAddress], | ||
staleTime: 1000 * 60 * 60, // 1 hour | ||
enabled: !!userAddress, | ||
select: (data) => { | ||
if (!data) { | ||
return null; | ||
} | ||
|
||
// Convert all APR values to APY using monthly compounding | ||
const convertedActionsAPY: Record<string, number> = {}; | ||
|
||
Object.entries(data.currentAPR.actionsAPR).forEach(([action, apr]) => { | ||
if (apr !== null && apr !== undefined) { | ||
const aprDecimal = apr / 100; // Convert to decimal | ||
const apy = convertAprToApy(aprDecimal); | ||
convertedActionsAPY[action] = apy * 100; // Convert back to percentage | ||
} | ||
}); | ||
|
||
return { | ||
...data, | ||
currentAPR: { | ||
...data.currentAPR, | ||
actionsAPY: convertedActionsAPY, // Add converted APY values | ||
}, | ||
}; | ||
}, | ||
}); | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend to use only a hook for Merit and for each MeritAction key take the userAPR and if not available general APR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NandyBa how often is the user apr data updated, would it be common that we might not have the users data from the api?
Also just wanted to clarify that the user apr would include any boosters or penalties applied based on the campaign rules right?