Dan Z-F pull request #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istAllMembers+Test. There are some specs (alphabetize, spacing) that need to be ironed out.
…r the UnitCorn. Fuck the UnitCorn.
…ods method, and need to implement runTests.
…t Test annotated methods.
…n't probably been totally fulfilled, but it looks like the UnitCorn is working for the simple cases I've created. Next will be making a larger dummy test class to explore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need more robust testing.
If I have the time, I'm going to do some refactoring, possibly to let the method that captures JUnit Test annotated methods take a String as input that would let it decide whether it wants to capture a Test, Before, or After.
I haven't really thought through how I would make use of the Before and After annotated methods, but I think they or the results of the methods that call them would belong in the runTest method. I can also do some cleaning up to increase my methods' adherence to SRP.
Also, I should probably have runTests return an ArrayList and then have a resultsToString method to call on that ArrayList. As is, I'm not actually saving that ArrayList anywhere.