Send Kafka a TERM signal at pod stop and wait for shutdown #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c60c28d.
|
The last log entry I see is |
|
Maybe Zookeeper doesn't need controlled shutdown. I see no effect in logs of invoking the script. |
|
I'm unable to reproduce the bad indices. I don't know how I ended up with them in the first place. We've been having a lot of pod restarts and failed probes running in AKS, so it could've been caused by a lot of different factors. |
|
But this is PR is certainly a step in the right direction 👍 |
|
I had bad indexes again after my disks went full. Maybe that is a "good way" to simulate broken indexes.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #206.
Based on https://github.com/apache/kafka/blob/trunk/bin/kafka-server-stop.sh and https://github.com/apache/kafka/blob/trunk/bin/zookeeper-server-stop.sh but these scripts don't wait for shutdown to complete.
Got the wait loop from https://stackoverflow.com/questions/17894720/kill-a-process-and-wait-for-the-process-to-exit
Currently I've only tested the PR locally with little load. @stigok Can you confirm that you no longer get corrupted indices?