Fix rbac to set useful labels on broker pods from init script #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 096e3bd.
to speed up a bit and reduce the risk that it interferes with actual config. Also if the init script goes crash looping you won't get warnings about labels already being set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought kubernetes/kubernetes#55329 would make such labels obsolete, but seeing that k8s 1.9 sets for example
statefulset.kubernetes.io/pod-name: kafka-0I think they complement each other.Moreover #78 depends on the
kafka-broker-idfor the./outsite-services/per-broker service.