Additional RBAC for Prometheus #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
though I first interpreted the error as the SA not being found level=error ts=2017-11-06T09:37:54.446320099Z caller=main.go:211 component=k8s_client_runtime err="github.com/prometheus/prometheus/discovery/kubernetes/kubernetes.go:245: Failed to list *v1beta1.Ingress: ingresses.extensions is forbidden: User \"system:serviceaccount:monitoring:prometheus-custom\" cannot list ingresses.extensions at the cluster scope: Unknown user \"system:serviceaccount:monitoring:prometheus-custom\""
solsson
force-pushed
the
rbac-prometheus
branch
from
8278415 to
af9e01b
Compare
sufficient RBAC already, and each additional instance can add something like custom's rbac.yaml if needed. No warnings remain in logs.
|
It's a lot easier to keep related RBAC resouces in the same file. Typically manifests don't have these kind of 1:1 (roughly) dependencies, but here they clearly do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4 I didn't nail RBAC for GKE. This PR solves some scraping already, but there's still som warnings in
prometheus-k8s's log.