Skip to content

For some reason, container names now seem to allow _ and - characters… #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2018
Merged

For some reason, container names now seem to allow _ and - characters… #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build-contract
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ fi

function wait_for_contract {
sleep 3
compose_name=$(echo "$1" | sed 's/[^A-Za-z0-9]//g')
compose_name=$(echo "$1" | sed 's/[^A-Za-z0-9_-]//g')
# Count the number of failed containers
# NOTE: Assumes no other build contract process is running at the same time
filters="-f label=com.yolean.build-contract -f name=$compose_name"
Expand Down