Fix Set key type for isBatchKeyASet + ts-reset #356
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the release of TypeScript types in #355 there is one single error remaining in our internal service. It looks like TypeScript + ts-reset does not infer a string union type when using the
getNewKeyTypeFromBatchKeySetType
helper, according to this rule:Because of the reset override, TypeScript infers the parameter type of
Set.prototype.has
to be astring
, rather than the generic type of theSet
.We can fix this by using a type inference instead,
T extends Set<infer U> ? U : never;
. This is arguably the more "correct" way to do it anyway.After linking in the patched dataloader-codegen we no longer have any type errors in our dataloaders. I did not add a regression test as this is specific to users of
ts-reset
and the existing coverage fromtestExampleTypes/swapi.ts
should cover the happy path.