[AIEX] Refactor Set/GetControlRegister and UPS instruction selection to share common code #712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinay-anubola
requested review from
F-Stuckmann,
SagarMaheshwari99,
abnikant,
andcarminati,
katerynamuts,
khallouh,
konstantinschwarz,
martien-de-jong,
mludevid,
niwinanto and
stephenneuendorffer
as code owners
| case AIE2::crF2FMask: | ||
| case AIE2::crF2IMask: | ||
| case AIE2::crFPMask: | ||
| return SrcConstVal % (1 << 5); |
Collaborator
There was a problem hiding this comment.
Perhaps we can generalize this using getRegSizeInBits(Reg, MRI)
Collaborator
There was a problem hiding this comment.
Hmm. It looks as if their size is 32 bit...
| // the register according to register width. | ||
| switch (CtrlReg) { | ||
| case AIE2::crSat: | ||
| return SrcConstVal % (1 << 2); |
Collaborator
There was a problem hiding this comment.
CHECK: this is mimicking the hardware when it would move it from a register source. To be frank, I would prefer a frontend error on writing an out of bound constant value.
| // Check if the argument is constant for register map index. | ||
| const auto Idx = getIConstantVRegValWithLookThrough(IdxReg, MRI); | ||
| if (!Idx) | ||
| llvm_unreachable("Expected const value for control register map index."); |
Collaborator
There was a problem hiding this comment.
getIConstantVRegValWithLookThroughOrFail() could encapsulate the llvm_unreachable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also support get/set_status_reg in instruction selection for AIE2P