-
Notifications
You must be signed in to change notification settings - Fork 29
feat(tosa): sink tosa ops through tosa.concat #671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: aie-public
Are you sure you want to change the base?
Conversation
jorickert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, especially for adding so many tests.
It looks generally good to me, but I will need to think about the reshape again, the current implementation seems to only handle some cases
This is correct. Only reshapes that extend or lessen the shape with dimensions of rank 1 will be transformed. This seemed to be enough for real-world tests, so I left it that way, with the possibility to handle more advanced cases later. Maybe I can add a comment explaining this. |
b3b89b2 to
4a5a491
Compare
|
All comments should be addressed now. |
6c863cd to
b6522a8
Compare
ehsan-toosi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did an high-level review and checked the transformation. Just one major comment which was using trait as you and Jonas already discussed as well.
I'll do the detailed code review if I find some time today.
3fc814b to
668aed2
Compare
roberteg16
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice! I have yet to finish the review of the reshape, I'll come back ASAP
roberteg16
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I would like just to have a few more reshape tests
c11c500 to
33a4759
Compare
33a4759 to
2fda478
Compare
2fda478 to
0803705
Compare
0803705 to
ba93cf8
Compare
|
Changes from 0803705 to ba93cf8:
|
a712731
|
I added a second commit to have options to disable parts of the pass for better testing. This could be extended to optionally disable the relu operations mentioned above, if they get problematic. |
|
Thanks. |
Currently supports elementwise and reduce operations, additional to matmul and reshape (within a limited set).
Could be extended to other operations later.