Revert DLC cooking + some improvements #53
Conversation
robojumper
left a comment
robojumper
left a comment
There was a problem hiding this comment.
Seems fine to me. Not being able to rely on base game TFCs is unfortunate, but at least mods get their own GPCD, so there's also a win here. Seems there's no perfect solution 🤷.
| Write-Host "" | ||
| Write-Host "Using cached release script packages" | ||
| Write-Host "If you've made changes to (or added) classes which are referenced by assets, please rebuild the mod in release (aka default) once to cache them" | ||
| Write-Host "" |
There was a problem hiding this comment.
Is this something a better incremental build system could do automatically? Worth filing an issue about?
There was a problem hiding this comment.
I'm not sure how feasible it would be to get an automated logic that would achieve a perfect balance between detecting all relevant changes and avoiding rebuilding when the changes are irrelevant, but we could explore the details in a separate issue
| # Revert ini | ||
| try { | ||
| $this.sdkEngineIniContentOriginal | Set-Content $this.sdkEngineIniPath -NoNewline | ||
| Write-Host "Reverted $($this.sdkEngineIniPath)" | ||
| } | ||
| catch { | ||
| FailureMessage "Failed to revert $($this.sdkEngineIniPath)" | ||
| FailureMessage $_ | ||
| } |
There was a problem hiding this comment.
This is the same behavior as before, but I think it's problematic that this prints an error message in the middle of the log (several screen heights above the success message) and then reports a successful build. I filed #54.
There was a problem hiding this comment.
Agreed, this could be a nasty surprise for someone. Thanks for the issue
pledbrook
left a comment
pledbrook
left a comment
There was a problem hiding this comment.
Things of note:
- If you specify a map in
sfMaps, there's no warning or error that I can see (it does error if ansfStandalonepackage is missing - If an entry is missing from ContentOptions.json, the file in ContentForCook is just ignore (I think this is OK, but wanted to mention it)
I haven't noticed anything else. Seems to work just fine.
Both are "checked" when the cooked packages are copied to the staging directory. If the source packages don't exist the cooker won't produce a cooked one, so |
This reverts the DLC cooking approach (#46) and also implements some improvements to the previous/original approach: