[Snyk] Upgrade ws from 8.13.0 to 8.18.2 #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snyk has created this PR to upgrade ws from 8.13.0 to 8.18.2. See this package in npm: ws See this project in Snyk: https://app.snyk.io/org/sammytezzy/project/ec97276b-1de6-4f4d-9753-599e3038434b?utm_source=github&utm_medium=referral&page=upgrade-pr
|
|
|
Reviewer's GuideThis PR upgrades the ws dependency from v8.13.0 to v8.18.2 to address a high-severity DoS vulnerability (SNYK-JS-WS-7266574) by updating the version spec in package.json and regenerating the lockfile. Sequence Diagram: 'ws' Upgrade - DoS Vulnerability FixsequenceDiagram
actor Attacker
participant AppServer [Application Server (using ws 8.18.2)]
Note over Attacker, AppServer: Scenario: Attacker attempts DoS with excessive headers/malformed message.
Attacker->>+AppServer: Malicious WebSocket Request (e.g., excessive headers)
AppServer->>AppServer: 'ws' library (v8.18.2) processes request
Note over AppServer: Patched logic correctly handles malicious input
AppServer-->>Attacker: Appropriate Error Response or Rejection
deactivate AppServer
Note right of AppServer: Server remains operational, DoS averted.<br/>(Previous versions were vulnerable to SNYK-JS-WS-7266574)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snyk has created this PR to upgrade ws from 8.13.0 to 8.18.2.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 11 versions ahead of your current version.
The recommended version was released 23 days ago.
Issues fixed by the recommended upgrade:
SNYK-JS-WS-7266574
Release notes
Package name: ws
-
8.18.2 - 2025-05-03
-
8.18.1 - 2025-02-21
- The length of the UNIX domain socket paths in the tests has been shortened to
-
8.18.0 - 2024-07-03
- Added support for
-
8.17.1 - 2024-06-16
- Fixed a DoS vulnerability (#2231).
const http = require('http');
- Reduce the maximum allowed length of the request headers using the
- Set
-
8.17.0 - 2024-04-28
- The
- The default value of the
-
8.16.0 - 2023-12-26
- Added the
-
8.15.1 - 2023-12-12
- The
-
8.15.0 - 2023-12-09
-
8.14.2 - 2023-09-19
-
8.14.1 - 2023-09-08
-
8.14.0 - 2023-09-06
-
8.13.0 - 2023-03-10
from ws GitHub release notesBug fixes
Fixed an issue that, during message decompression when the maximum size was
exceeded, led to the emission of an inaccurate error and closure of the
connection with an improper close code (#2285).
Bug fixes
make them work when run via CITGM (021f7b8).
Features
Blob(#2229).Bug fixes
A request with a number of headers exceeding the
server.maxHeadersCountthreshold could be used to crash a ws server.
const WebSocket = require('ws');
const wss = new WebSocket.Server({ port: 0 }, function () {
const chars = "!#$%&'*+-.0123456789abcdefghijklmnopqrstuvwxyz^_`|~".split('');
const headers = {};
let count = 0;
for (let i = 0; i < chars.length; i++) {
if (count === 2000) break;
}
headers.Connection = 'Upgrade';
headers.Upgrade = 'websocket';
headers['Sec-WebSocket-Key'] = 'dGhlIHNhbXBsZSBub25jZQ==';
headers['Sec-WebSocket-Version'] = '13';
const request = http.request({
headers: headers,
host: '127.0.0.1',
port: wss.address().port
});
request.end();
});
The vulnerability was reported by Ryan LaPointe in #2230.
In vulnerable versions of ws, the issue can be mitigated in the following ways:
--max-http-header-size=sizeand/or themaxHeaderSizeoptions sothat no more headers than the
server.maxHeadersCountlimit can be sent.server.maxHeadersCountto0so that no limit is applied.Features
WebSocketconstructor now accepts thecreateConnectionoption (#2219).Other notable changes
allowSynchronousEventsoption has been changed totrue(#2221).This is a breaking change in a patch release. The assumption is that the option
is not widely used.
Features
autoPongoption (01ba54e).Notable changes
allowMultipleEventsPerMicrotaskoption has been renamed toallowSynchronousEvents(4ed7fe5).This is a breaking change in a patch release that could have been avoided with
an alias, but the renamed option was added only 3 days ago, so hopefully it
hasn't already been widely used.
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
Summary by Sourcery
Upgrade the ws dependency to version 8.18.2 to address a high-severity Denial of Service vulnerability.
Bug Fixes:
Enhancements: