no_entrypoint_imports #86
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
An entrypoint import can be defined as an import within
lib/src
that imports a file withinlib/*.dart
(the entrypoints of a dart package). These imports are always unnecessary, and can contribute to slower dart build performance.Solution
This PR naively removes every entrypoint import within the repo, and updates the
gha-dart/.../checks.yaml
to the latest version. In order to merge this PR a few manual changes must be performed:no_entrypoint_imports
additional-checks option in[email protected]
that was added in this PR. This will prevent new entrypoint imports from getting added once this PR mergesOur request to teams is to perform the above tasks, so we can default enable the
no_entrypoint_imports
check for all gha-dart consumers. Please reach out to #support-frontend-dx for any questions or issuesQA
Created by Sourcegraph batch change
Workiva/no_entrypoint_imports
.