Skip to content

Critical usability issues : stuck loading modules + parser_xml_output #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+17 −17
Open

Critical usability issues : stuck loading modules + parser_xml_output #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f7e313
Corrected parse_xml_output path error when looking for tmp output files
diegantobass Nov 9, 2015
ba4d04b
Supressed progress bar when loading modules in server (issue #11)
diegantobass Nov 9, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions corenlp/corenlp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ def parse_xml_output(input_dir, corenlp_path=DIRECTORY, memory="3g", raw_output=
# result = []
try:
for output_file in os.listdir(xml_dir):
with open(os.path.join(xml_dir + output_file), 'r') as xml:
with open(os.path.join(xml_dir, output_file), 'r') as xml:
# parsed = xml.read()
file_name = re.sub('.xml$', '', os.path.basename(output_file))
# result.append(parse_parser_xml_results(xml.read(), file_name,
Expand Down Expand Up @@ -314,22 +314,22 @@ def _spawn_corenlp(self):
self.corenlp = pexpect.spawn(self.start_corenlp, maxread=8192,
searchwindowsize=80)

# show progress bar while loading the models
if VERBOSE:
widgets = ['Loading Models: ', Fraction()]
pbar = ProgressBar(widgets=widgets, maxval=5, force_update=True).start()
# Model timeouts:
# pos tagger model (~5sec)
# NER-all classifier (~33sec)
# NER-muc classifier (~60sec)
# CoNLL classifier (~50sec)
# PCFG (~3sec)
timeouts = [20, 200, 600, 600, 20]
for i in xrange(5):
self.corenlp.expect("done.", timeout=timeouts[i]) # Load model
pbar.update(i + 1)
self.corenlp.expect("Entering interactive shell.")
pbar.finish()
# # show progress bar while loading the models
# if VERBOSE:
# widgets = ['Loading Models: ', Fraction()]
# pbar = ProgressBar(widgets=widgets, maxval=5, force_update=True).start()
# # Model timeouts:
# # pos tagger model (~5sec)
# # NER-all classifier (~33sec)
# # NER-muc classifier (~60sec)
# # CoNLL classifier (~50sec)
# # PCFG (~3sec)
# timeouts = [20, 200, 600, 600, 20]
# for i in xrange(5):
# self.corenlp.expect("done.", timeout=timeouts[i]) # Load model
# pbar.update(i + 1)
# self.corenlp.expect("Entering interactive shell.")
# pbar.finish()

# interactive shell
self.corenlp.expect("\nNLP> ")
Expand Down