playground.wordpress.net: Support mounting local files #548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
changed the title
adamziel
added
[Type] Enhancement
adamziel
force-pushed
the
mount-local-directory
branch
from
e4b1bd7 to
58b4b4b
Compare
dmsnell
added a commit
that referenced
this pull request
Jun 16, 2023
When mounting local directories in #548, problems appeared in development builds because the dev environemnt runs a separate server for the website that wraps the iframe and the for the assets inside the iframe, the "remote." In this patch we're adjusting the config for the outer website server so that we can proxy requests for the internal frame through the same origin. This is done by adding a prefix to the URL for the dev assets on the outer frame, which then is used in a proxy rule to decide what to route. This means that OPFS handles can be shared between the two sides of the iframe, which normally happens in production since they both come from the same origin.
dmsnell
added a commit
that referenced
this pull request
Jun 16, 2023
When mounting local directories in #548, problems appeared in development builds because the dev environemnt runs a separate server for the website that wraps the iframe and the for the assets inside the iframe, the "remote." In this patch we're adjusting the config for the outer website server so that we can proxy requests for the internal frame through the same origin. This is done by adding a prefix to the URL for the dev assets on the outer frame, which then is used in a proxy rule to decide what to route. This means that OPFS handles can be shared between the two sides of the iframe, which normally happens in production since they both come from the same origin.
adamziel
pushed a commit
that referenced
this pull request
Jun 18, 2023
When mounting local directories in #548, problems appeared in development builds because the dev environemnt runs a separate server for the website that wraps the iframe and the for the assets inside the iframe, the "remote." In this patch we're adjusting the config for the outer website server so that we can proxy requests for the internal frame through the same origin. This is done by adding a prefix to the URL for the dev assets on the outer frame, which then is used in a proxy rule to decide what to route. This means that OPFS handles can be shared between the two sides of the iframe, which normally happens in production since they both come from the same origin.
adamziel
pushed a commit
that referenced
this pull request
Jun 18, 2023
When mounting local directories in #548, problems appeared in development builds because the dev environemnt runs a separate server for the website that wraps the iframe and the for the assets inside the iframe, the "remote." In this patch we're adjusting the config for the outer website server so that we can proxy requests for the internal frame through the same origin. This is done by adding a prefix to the URL for the dev assets on the outer frame, which then is used in a proxy rule to decide what to route. This means that OPFS handles can be shared between the two sides of the iframe, which normally happens in production since they both come from the same origin.
adamziel
added a commit
that referenced
this pull request
Jun 18, 2023
When mounting local directories in #548, problems appeared in development builds because the dev environemnt runs a separate server for the website that wraps the iframe and the for the assets inside the iframe, the "remote." In this patch we're adjusting the config for the outer website server so that we can proxy requests for the internal frame through the same origin. This is done by adding a prefix to the URL for the dev assets on the outer frame, which then is used in a proxy rule to decide what to route. This means that OPFS handles can be shared between the two sides of the iframe, which normally happens in production since they both come from the same origin. Co-authored-by: Adam Zieliński <[email protected]>
adamziel
added a commit
that referenced
this pull request
Jun 18, 2023
When mounting local directories in #548, problems appeared in development builds because the dev environemnt runs a separate server for the website that wraps the iframe and the for the assets inside the iframe, the "remote." In this patch we're adjusting the config for the outer website server so that we can proxy requests for the internal frame through the same origin. This is done by adding a prefix to the URL for the dev assets on the outer frame, which then is used in a proxy rule to decide what to route. This means that OPFS handles can be shared between the two sides of the iframe, which normally happens in production since they both come from the same origin. Co-authored-by: Adam Zieliński <[email protected]>
|
This now works and even stores the directory handle between page refreshes. Caveat: that handle can only be restored in a click event handler. To remedy that I added an open-by-default modal when 
The wording could be better. Also, React components code got a bit messy in the process and could use some cleaning up. |
adamziel
force-pushed
the
mount-local-directory
branch
from
2ae3869 to
c97c9d6
Compare
Closed
This is somewhat unfair, and even though the Why? Because we're asking "do you want?" and the only possible choice we give someone is "Yes." |
adamziel
force-pushed
the
mount-local-directory
branch
from
b871c70 to
18b2f35
Compare
adamziel
force-pushed
the
mount-local-directory
branch
from
18b2f35 to
d48991f
Compare
|
Here's the updated modal: 
|
|
I've also learned the MEMFS->OPFS sync is so slow because Chrome writes everything to a temp file, scans it, and only then creates the actual file. There is chromium work underway to make it faster in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #547 adds support for OPFS API, I just realized the same API can be used to read/write local files. This PR adds a local directory picker and a "refresh" button to bring the changes back into Playground's MEMFS.
Testing instructions
Other considerations
wp-nowcould be really handy here. It would have to be refactored to use shared, isomorphic feature that works throughphpmethods likephp.readFileAsBuffer()which means they'll need some enhancements like support for reading the first 8kb.refresh filesbutton as everything would be stored and read directly from OPFS. Persistent Playground: Explore OPFS support #544 started exploring that but it uses the deprecated sync API. We'd need to find a way to use the new async one.