SCF v6.6.0 Broke Free into ACF

[bsienn-khan]

SCF broke the wall and changed intelf into ACF with wp-engine GUI and banners.
Seriously just lost few brain cells finding this out.

Workaround: add the MY_ACF_PATH constant in wp-config.php

// Define path and URL to the bundled ACF code.
define( 'MY_ACF_PATH', DIR . 'wp-content/plugins/secure-custom-fields/' );

[cbravobernal]

Thanks for the report! At the moment there isn’t enough information for us to identify a specific bug or problem in SCF. The issue also doesn’t follow the project’s contribution guidelines, as it lacks details such as steps to reproduce, expected/actual behavior, or screenshots.

If you’re experiencing a specific problem, please share clear reproduction steps so we can investigate. I’m going to close this for now, but we’re happy to reopen it if more details are provided. Thanks!

[priethor]

Please verify you are actually using SCF on the same site. I can confirm this doesn't happen with a fresh SCF install:

Moreover, the string Activate your license doesn't exist in the SCF codebase at all.

[bsienn-khan]

@priethor Hi, I added 2 windows in the screenshot one for the plugins.
I just updated plugins using the wp plugins update --all

I'll try to add more details soon.

[priethor]

@priethor Hi, I added 2 windows in the screenshot one for the plugins.

Thanks, but I can' see if it's the same site 🙂

I just updated plugins using the wp plugins update --all

Which version were you running before updating?

[priethor]

I just tested upgrading from 6.5.7 and it succeeded, downloading the official version from https://downloads.wordpress.org/plugin/secure-custom-fields.6.6.0.zip

[bsienn-khan]

It is just a blank site, only have bricks, AT, SCF & query monitor installed.
Latest wordpress and SCF was Version 6.5.7.

Edit: O shoot, I found the issue. Let me get back in a minute, with an apology as well.

[bsienn-khan]

I have put whole project in repository. I upgraded SCF today, and activated it along with an other plugin, Advanced Themer.
This is just a blank site, really not a single page in it. just a starting point with base wordpress.

So when I activated SCF & AT, I saw SCF changed to ACF. I lost my temper and did overreacted making this issue. Wasn't totally my intention.

So AT which used to come with ACF Pro by default for free, and later removed it still has something going on behind the scene.
It replaced SCF to ACF. Blimey.

I'm sorry for jumping to finger pointing, you can see my 5-start review on SCF from way back, I just got hit with this and lost it.

[priethor]

Thanks for the detailed explanation; we're all human here and just trying to help, so we're glad you reached out!

Can you say more about AT using/switching SCF? I can't find any info about it; I am not familiar with it, and don't see anything related to Custom Fields in their docs.

[bsienn-khan]

I just tested it, I can make a screencast replicating the issue, if you wan't.
I can't share the repo as it won't work without the license keys.

I'm not sure why would AT do the coupe, I just noticed it.
Don't know if it's by design from AT or just some random glitch.

AT(advancedthemer.com) is a Bricks-Builder addon
It used to come pre-packed with ACF-Pro with their LTD license while back, not anymore.

I have latest LDT license, which doesn't come with ACF-Pro.

I do find it a bit irritating that some other plugin messed with an existing plugin files upon activation.
I'll report this issue to AT as well.

Let me know if I can help with anything else.

[cbravobernal]

We cannot ( should not too ) deal with external premium plugins behaviours I'm afraid 😅

[bsienn-khan]

Thank you both for your time, cheers.

[priethor]

Thanks, Abdu, for the extra info; no need to screencast. I understand the confusion it can generate for users, but whatever changes other plugins do that affect (and rightfully confuse 😅 ) their users like this is something we can't handle.

I would be happy to reach out to them to learn more about their SCF use case or lack thereof, but I don't see anything on their site related to it.

[bsienn-khan]

Hi, so i got home and checked the AT setup. Basically it does come with its own bundled ACF plugin, and the AT has a start script as follow:

I do understand this is out of the scope of SCF but I thought I would share.
Reading the script gave me a pointer for a workaround as follows:

Workaround: add the MY_ACF_PATH constant in wp-config.php

// Define path and URL to the bundled ACF code.
define( 'MY_ACF_PATH', DIR . 'wp-content/plugins/secure-custom-fields/' );

I'm so glad to be a programmer & that I could read code.
I fixed a problem was forced on me.

<?php

/**
 * Load all application modules.
 *
 * @package Bricks_Advanced_Themer
 */

defined('ABSPATH') || die();

global $brxc_acf_already_exists;

function brxc_init_plugin(){

    include_once __DIR__ . '/const.php';

    if (!class_exists('Advanced_Themer_Bricks\AT__Init')) {

        require_once plugin_dir_path( __FILE__ ) . 'classes/init.php';

        Advanced_Themer_Bricks\AT__Init::init_hooks();
    }
    
}

function brxc_check_license_date($unicode){
    // Unix timestamp of April 1st, 2024
    $april2024Timestamp = 1711922400;

    // Check if the provided timestamp is higher than the April 2024 timestamp
    return intval($unicode) < $april2024Timestamp;
}

// Include ACF PRO only if it's not installed yet

if ( ! function_exists( 'is_plugin_active' ) ) {
	include_once ABSPATH . 'wp-admin/includes/plugin.php';
}

// Check if ACF PRO is active
if ( is_plugin_active( 'advanced-custom-fields-pro/acf.php' ) ) {
	// Abort all bundling, ACF PRO plugin takes priority
	return add_action( 'plugins_loaded', 'brxc_init_plugin' );
}

// Check if another plugin or theme has bundled ACF
if ( defined( 'MY_ACF_PATH' ) ) {
	return add_action( 'plugins_loaded', 'brxc_init_plugin' );;
}

// Define path and URL to the bundled ACF code.
define( 'MY_ACF_PATH', __DIR__ . '/plugins/acf-pro/' );
define( 'MY_ACF_URL', plugin_dir_url( __FILE__ ) . 'plugins/acf-pro/' );

// Include the ACF plugin.
include_once( MY_ACF_PATH . 'acf.php' );

// Customize the URL setting to fix incorrect asset URLs.
add_filter( 'acf/settings/url', function( $url ) {
	return MY_ACF_URL;
} );

// Check if the ACF free plugin is activated
if ( is_plugin_active( 'advanced-custom-fields/acf.php' ) ) {
	// Free plugin activated
	// Show notice
	add_action( 'admin_notices', function () {
		?>
		<div class="updated" style="border-left: 4px solid #ffba00;">
			<p>The free version of ACF cannot be activated alongside Advanced Themer, as ACF is already bundled with AT. It has therefore been deactivated.</p>
		</div>
		<?php
	}, 99 );

	// Disable ACF free plugin
	deactivate_plugins( 'advanced-custom-fields/acf.php' );
}

// Check if ACF free is installed
if ( ! file_exists( WP_PLUGIN_DIR . '/advanced-custom-fields/acf.php' ) ) {
    add_action( 'init', 'Advanced_Themer_Bricks\AT__ACF::remove_acf_menu');
	add_filter( 'acf/settings/show_updates', '__return_false', 100 );
	add_filter( 'acf/settings/remove_wp_meta_box', '__return_false');
}

add_action( 'plugins_loaded', 'brxc_init_plugin' );