Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions tests/api/test_messages.py
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,24 @@ def test_get_message_by_id(api, group_room_text_message):
assert is_valid_message(message)


def test_update_message_by_id(api, group_room_text_message):
message = api.messages.update(
group_room_text_message.id,
roomId=group_room_text_message.roomId,
text=group_room_text_message.text+" updated!"
)
assert is_valid_message(message)
assert message.text.endswith(" updated!")

message = api.messages.edit(
group_room_text_message.id,
roomId=group_room_text_message.roomId,
text=group_room_text_message.text+" edited!"
)
assert is_valid_message(message)
assert message.text.endswith(" edited!")


def test_delete_message(api, group_room, send_group_room_message):
text = create_string("Message")
message = api.messages.create(group_room.id, text=text)
Expand Down
11 changes: 7 additions & 4 deletions webexteamssdk/api/messages.py
Original file line number Diff line number Diff line change
Expand Up @@ -339,11 +339,11 @@ def delete(self, messageId):
# API request
self._session.delete(API_ENDPOINT + '/' + messageId)

def edit(self, messageId=None, roomId=None, text=None, markdown=None):
"""Edit a message.
def update(self, messageId=None, roomId=None, text=None, markdown=None):
"""Update (edit) a message.

Args:
messageId(basestring): The ID of the message to be edit.
messageId(basestring): The ID of the message to be updated.
roomId(basestring): The room ID.
text(basestring): The message, in plain text. If `markdown` is
specified this parameter may be optionally used to provide
Expand All @@ -370,4 +370,7 @@ def edit(self, messageId=None, roomId=None, text=None, markdown=None):
json_data = self._session.put(API_ENDPOINT + '/' + messageId, json=put_data)

# Return a message object created from the response JSON data
return self._object_factory(OBJECT_TYPE, json_data)
return self._object_factory(OBJECT_TYPE, json_data)

# Add edit() as an alias to the update() method for backward compatibility
edit = update