Skip to content

Fixed simple property rendering (fixes CiscoDevNet/webexteamssdk#107) #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2020
Merged

Fixed simple property rendering (fixes CiscoDevNet/webexteamssdk#107) #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions webexteamssdk/models/cards/actions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ def __init__(self, data=None, title=None, iconURL=None):
self.iconURL = iconURL

super().__init__(
serializable_properties=['data'],
simple_properties=['title', 'iconURL', 'type'],
serializable_properties=[],
simple_properties=['data', 'title', 'iconURL', 'type'],
)


Expand Down
7 changes: 5 additions & 2 deletions webexteamssdk/models/cards/adaptive_card_component.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"""

import json

import enum

class AdaptiveCardComponent:
"""Base class for all Adaptive Card components.
Expand Down Expand Up @@ -63,7 +63,10 @@ def to_dict(self):
property_value = getattr(self, property_name, None)

if property_value is not None:
serialized_data[property_name] = str(property_value)
if isinstance(property_value, enum.Enum):
property_value = str(property_value)

serialized_data[property_name] = property_value

# Recursively serialize sub-components
for property_name in self.serializable_properties:
Expand Down