Add Tracking IDs to all API Errors and Warnings #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for the Admin Audit Events API
Add the `trackingId` returned in Webex API responses to the library API errors and warnings. Clean-up exception and warning inheritance to reduce code duplication and provide a consistent inheritance hierarchy.
|
Looks great to me! I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tracking ID is now prominently displayed in the printed output of all API errors and warnings, and it is available via the
tracking_idattribute on caughtApiErrorexceptions and warnings.Example:
I also added an inheritance hierarchy for warnings and ensured that all
ApiErrorandApiWarningobjects have consistent attributes including the newtracking_idattribute.